chore(ci): Fixes for version checks upon release #671
Conversation
dmihalcik-virtru
commented
Jul 1, 2025
dmihalcik-virtru
commented
- The version information must be up to date and accurate before tagging and publishing releases
- The version information must be up to date and accurate before tagging and publishing releases
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the continuous integration process by upgrading the version validation script. The primary goal is to ensure that all relevant version information is consistently and accurately reflected across the codebase before any release is tagged and published, thereby preventing discrepancies and ensuring release integrity.
Highlights
- Enhanced Version Detection Logic: The
check-version-is.shscript now intelligently determines the expected version by parsing various inputs, including GitHubrefcontexts (release branch names, tag names) and direct semantic version strings, improving its adaptability in CI/CD pipelines. - Improved Error Reporting Precision: The script's error messages for
Makefileandlib/src/version.tsnow use more precise line number detection by anchoring regexes to the start of the line, leading to more accurate feedback.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
There was a problem hiding this comment.
Code Review
The pull request introduces improvements to the version checking script, enhancing its ability to accurately validate version numbers across different files and contexts. The changes include parsing version information from release branches and tags, and refining the grep and sed commands for more precise version lookups. The review focuses on ensuring the sed commands are correctly anchored to prevent unintended matches.
|
/backport |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-671-to-release/sdk/v0.4
git worktree add --checkout .worktree/backport-671-to-release/sdk/v0.4 backport-671-to-release/sdk/v0.4
cd .worktree/backport-671-to-release/sdk/v0.4
git reset --hard HEAD^
git cherry-pick -x 0e978991041beaab1ed006a3726d2cd0a69d881d
git push --force-with-lease |
- The version information must be up to date and accurate before tagging and publishing releases (cherry picked from commit 0e97899)
- The version information must be up to date and accurate before tagging and publishing releases (cherry picked from commit 0e97899) Co-authored-by: Dave Mihalcik <[email protected]> Co-authored-by: el-virt <[email protected]>
